Adjust to the moved Helm chart #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including removal related CI build
willmostly
approved these changes
Dec 2, 2024
Contributor
willmostly
left a comment
willmostly
left a comment
There was a problem hiding this comment.
one comment but I think this is good to merge
| @@ -204,8 +204,16 @@ java -XX:MinRAMPercentage=50 -XX:MaxRAMPercentage=80 \ | |||
| ### Helm <a name="helm"></a> | |||
Contributor
There was a problem hiding this comment.
This section is linked from docker.md - perhaps it should just link directly to the chart repo - wdyt?
Member
Author
There was a problem hiding this comment.
No .. I want to keep this since I want to actually get this onto a separate page and much improved.. so for now .. lets leave as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in dev sync.
Additional context and related issues
Related to trinodb/charts#268
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.